Skip to content
Snippets Groups Projects
  1. Apr 07, 2013
  2. Apr 05, 2013
    • jsiegle's avatar
      Run astyle to make code format more consistent · ea8c1c90
      jsiegle authored
      To run this in the future, install astyle (sudo apt-get install astyle),
      then enter the following from the top-level project directory:
      
      astyle --options=astyle.options --recursive "./Source/*.cpp" "./Source/*.h"
      
      This will convert tabs to 4 spaces and ensure that brackets are on
      their own lines.
      ea8c1c90
  3. Mar 21, 2013
    • jsiegle's avatar
      Change copyright year to 2013 · e36119a1
      jsiegle authored
      Use the following command to update the copyright year in all files,
      starting in the Source/ directory:
      
      find . -type f -print0 | xargs -0
         sed -i 's/Copyright (C) 2012/Copyright (C) 2013/g'
      
      Works like a charm!
      e36119a1
    • jsiegle's avatar
      Updated JUCE library · 637baf17
      jsiegle authored
      637baf17
  4. Feb 12, 2013
    • Marti Bolivar's avatar
      GenericProcessor: fix missing return values. · 8d0a53d4
      Marti Bolivar authored
      
      getInputChannelName() and getOutputChannelName() (pure virtual in the
      superclass) aren't returning anything. So far this hasn't triggered
      any memory errors because nobody's calling them.
      
      To hack around this, have both of these return
      "xxx-UNUSED-OPEN-EPHYS-xxx" (none of the existing subclases override
      these methods, so leaving them pure virtual isn't workable). This way,
      if we ever start calling these, we'll notice right away that a fix is
      needed (instead of segfaulting, etc.).
      
      Also keep them virtual to allow overrides.
      
      Signed-off-by: default avatarMarti Bolivar <mbolivar@leaflabs.com>
      8d0a53d4
    • Marti Bolivar's avatar
      GenericProcessor: don't return a reference to a stack variable. · e48cde4a
      Marti Bolivar authored
      
      That's not gonna work. Since nullParam is just a "nothing found", put
      it in static storage and return that.
      
      Signed-off-by: default avatarMarti Bolivar <mbolivar@leaflabs.com>
      e48cde4a
    • Marti Bolivar's avatar
      Fix up unused variable/value warnings. · 12574cf1
      Marti Bolivar authored
      
      Generic changes:
      
      - Genuinely unused variables (-Wunused-variable): delete
        them. Sometimes add a comment if the variable is for an extension of
        the code that isn't done yet.
      
      - Variables that became unused due to commented-out
        code (-Wunused-variable): comment out their definitions. Dirty, but
        that's because commenting out code instead of deleting it is
        dirty.
      
        Many of these are due to commented-out printlines that should have
        been log messages that only get emitted at high verbosity level.
      
      Specific changes:
      
      - SpikeObject.cpp (-Wunused-value): move initialization of loop
        variable into first for loop clause to silence the warning.
      
      Signed-off-by: default avatarMarti Bolivar <mbolivar@leaflabs.com>
      12574cf1
    • Marti Bolivar's avatar
      Resolve -Wreorder warnings. · efe43aa8
      Marti Bolivar authored
      
      Rearrange member initialization in constructors to silence GCC
      -Wreorder warnings (-Wreorder is enabled by -Wall).
      
      Signed-off-by: default avatarMarti Bolivar <mbolivar@leaflabs.com>
      efe43aa8
  5. Feb 06, 2013
  6. Jan 28, 2013
    • Ryan Maloney's avatar
      Saving Parameters · 58c8797d
      Ryan Maloney authored
      Uses the parameters array to create XML data for parameter settings on
      each channel when saving.
      
      This only works for processors that use the parameters array, though I
      updated LFP and Signal Generator to update that in parallel (LFP seems
      to have an unrelated bug in dealing with channels that is causing some
      problems). Eventually, all parameters should be used in the parameters
      array, since it opens up a lot of possible holes when using default
      values (they need to be specified twice), and once loading is
      implemented. I've fixed some of the problems with parameters, so this
      should be easier to do.
      
      As part of this, I also fixed the implementation of
      addParameterEditors. The old way of implementing a custom parameter
      editor was to rewrite the virtual function, but because it was called
      in the constructor, this didn't work (constructors use the type of the
      parent). Instead, all editors now also pass a bool
      "useDefaultParameterEditors" which is used by addParameterEditors() to
      determine whether to do anything. I think this is the best way to do
      it. It's initialized to default as true, though I had some trouble with
      it implicitly taking the argument and so had to add true to most of the
      editor functions (which is probably good practice anyway).
      
      I also fixed some of the functions for generic processor to get
      parameter index and parameter name.
      
      Obviously, this is of considerable less use without functions for
      loading parameters, but I figured it'd be better to make available for
      testing with just the loading in case the changes to Parameters broke
      anything I missed.
      58c8797d
  7. Dec 27, 2012
  8. Nov 20, 2012
  9. Nov 19, 2012
  10. Nov 17, 2012
  11. Nov 16, 2012
  12. Nov 11, 2012
  13. Nov 10, 2012
  14. Nov 06, 2012
  15. Oct 06, 2012
  16. Sep 20, 2012
  17. Jun 18, 2012
  18. Jun 17, 2012
  19. May 20, 2012
  20. May 16, 2012
  21. May 15, 2012
  22. May 12, 2012
  23. Apr 22, 2012
  24. Apr 18, 2012
  25. Apr 13, 2012
    • jsiegle's avatar
      Redesigned channel selector buttons. · f5b78060
      jsiegle authored
      Channel selection now takes place within a slick new interface. It's not
      yet tied to actually changing parameters, but things should be much simpler
      code-wise, as well as visually.
      f5b78060
  26. Apr 11, 2012
  27. Apr 06, 2012
  28. Apr 05, 2012
  29. Apr 04, 2012
    • jsiegle's avatar
      Implemented rudimentary recording functionality for continuous channels · 90406533
      jsiegle authored
      If continuous channels are toggled for recording within their respective editors,
      a "writeContinuousBuffer" function will be activated within the RecordNode. This
      function doesn't do anything yet, but it will make it easy to add diskwriting
      capabilities in the near future. Once a stable format for events has been established,
      a similar function will be implemented for writing event buffers to disk.
      90406533
  30. Apr 02, 2012
Loading