- Apr 07, 2013
-
-
jsiegle authored
-
- Apr 05, 2013
-
-
jsiegle authored
To run this in the future, install astyle (sudo apt-get install astyle), then enter the following from the top-level project directory: astyle --options=astyle.options --recursive "./Source/*.cpp" "./Source/*.h" This will convert tabs to 4 spaces and ensure that brackets are on their own lines.
-
- Mar 21, 2013
- Feb 12, 2013
-
-
Marti Bolivar authored
getInputChannelName() and getOutputChannelName() (pure virtual in the superclass) aren't returning anything. So far this hasn't triggered any memory errors because nobody's calling them. To hack around this, have both of these return "xxx-UNUSED-OPEN-EPHYS-xxx" (none of the existing subclases override these methods, so leaving them pure virtual isn't workable). This way, if we ever start calling these, we'll notice right away that a fix is needed (instead of segfaulting, etc.). Also keep them virtual to allow overrides. Signed-off-by:
Marti Bolivar <mbolivar@leaflabs.com>
-
Marti Bolivar authored
That's not gonna work. Since nullParam is just a "nothing found", put it in static storage and return that. Signed-off-by:
Marti Bolivar <mbolivar@leaflabs.com>
-
Marti Bolivar authored
Generic changes: - Genuinely unused variables (-Wunused-variable): delete them. Sometimes add a comment if the variable is for an extension of the code that isn't done yet. - Variables that became unused due to commented-out code (-Wunused-variable): comment out their definitions. Dirty, but that's because commenting out code instead of deleting it is dirty. Many of these are due to commented-out printlines that should have been log messages that only get emitted at high verbosity level. Specific changes: - SpikeObject.cpp (-Wunused-value): move initialization of loop variable into first for loop clause to silence the warning. Signed-off-by:
Marti Bolivar <mbolivar@leaflabs.com>
-
Marti Bolivar authored
Rearrange member initialization in constructors to silence GCC -Wreorder warnings (-Wreorder is enabled by -Wall). Signed-off-by:
Marti Bolivar <mbolivar@leaflabs.com>
-
- Feb 06, 2013
-
-
aacuevas authored
-
- Jan 28, 2013
-
-
Ryan Maloney authored
Uses the parameters array to create XML data for parameter settings on each channel when saving. This only works for processors that use the parameters array, though I updated LFP and Signal Generator to update that in parallel (LFP seems to have an unrelated bug in dealing with channels that is causing some problems). Eventually, all parameters should be used in the parameters array, since it opens up a lot of possible holes when using default values (they need to be specified twice), and once loading is implemented. I've fixed some of the problems with parameters, so this should be easier to do. As part of this, I also fixed the implementation of addParameterEditors. The old way of implementing a custom parameter editor was to rewrite the virtual function, but because it was called in the constructor, this didn't work (constructors use the type of the parent). Instead, all editors now also pass a bool "useDefaultParameterEditors" which is used by addParameterEditors() to determine whether to do anything. I think this is the best way to do it. It's initialized to default as true, though I had some trouble with it implicitly taking the argument and so had to add true to most of the editor functions (which is probably good practice anyway). I also fixed some of the functions for generic processor to get parameter index and parameter name. Obviously, this is of considerable less use without functions for loading parameters, but I figured it'd be better to make available for testing with just the loading in case the changes to Parameters broke anything I missed.
-
- Dec 27, 2012
-
-
Josh Siegle authored
-
- Nov 20, 2012
-
-
unknown authored
-
- Nov 19, 2012
-
-
Josh Siegle authored
-
- Nov 17, 2012
-
-
Josh Siegle authored
-
Josh Siegle authored
-
- Nov 16, 2012
-
-
jsiegle authored
-
- Nov 11, 2012
-
-
jsiegle authored
-
- Nov 10, 2012
- Nov 06, 2012
-
-
jsiegle authored
-
Shay Ohayon authored
VS throws errors in several locations about ambigious type casting. Fixed by removing the ambiguities and casting things to double.
-
- Oct 06, 2012
-
-
Josh Siegle authored
-
- Sep 20, 2012
-
-
unknown authored
-
- Jun 18, 2012
-
-
Josh Siegle authored
-
- Jun 17, 2012
-
-
jsiegle authored
-
- May 20, 2012
-
-
jsiegle authored
-
- May 16, 2012
- May 15, 2012
-
-
jsiegle authored
-
- May 12, 2012
-
-
jsiegle authored
-
- Apr 22, 2012
-
-
jsiegle authored
-
- Apr 18, 2012
-
-
jsiegle authored
-
- Apr 13, 2012
-
-
jsiegle authored
Channel selection now takes place within a slick new interface. It's not yet tied to actually changing parameters, but things should be much simpler code-wise, as well as visually.
-
- Apr 11, 2012
-
-
jsiegle authored
-
- Apr 06, 2012
- Apr 05, 2012
-
-
jsiegle authored
-
- Apr 04, 2012
-
-
jsiegle authored
If continuous channels are toggled for recording within their respective editors, a "writeContinuousBuffer" function will be activated within the RecordNode. This function doesn't do anything yet, but it will make it easy to add diskwriting capabilities in the near future. Once a stable format for events has been established, a similar function will be implemented for writing event buffers to disk.
-
- Apr 02, 2012
-
-
jsiegle authored
-