Skip to content
Snippets Groups Projects
  1. Mar 19, 2014
  2. Jan 25, 2014
  3. Jan 22, 2014
  4. Jan 19, 2014
  5. Jan 18, 2014
  6. Oct 31, 2013
  7. Oct 30, 2013
    • jsiegle's avatar
      Use processor ID number as flag for saving · 75e0ce11
      jsiegle authored
      Previously, every event would be saved multiple times if
      it passed through multiple processors. Now,
      GenericProcessor::getNumSamples() checks for existing TTL
      events and changes the processor ID (byte 2) to zero.
      If the RecordNode encounters an event without a positive
      processor ID, it will ignore it.
      
      The only potentially dangerous thing about this is that it
      involves modifying the MidiBuffer. But as long as the size
      of the buffer doesn't change (just the value of certain
      bytes), this should be fine.
      75e0ce11
  8. Aug 24, 2013
  9. Aug 08, 2013
  10. Jul 23, 2013
  11. Jun 19, 2013
  12. May 26, 2013
  13. May 21, 2013
  14. May 10, 2013
  15. May 09, 2013
    • interpretivechaos's avatar
      Loading Parameters and altering Parameter Buttons based on active channels · 3a2ace62
      interpretivechaos authored
      Allows parameters to be set from saved XML and changes the
      parameterEditor buttons (currently for discrete parameters only) to
      reflect which parameters are currently used by selected and
      non-selected channels. This fixes a problem where the buttons would
      always show what the last press was rather than the current values for
      the active channels (e.g. If you changed the parameters on Channel 2,
      and then switched to select only Channel 1, the GUI would incorrectly
      indicate that the settings for Channel 2 were active). Additionally,
      allows the user to see what parameter values are used for channels not
      currently selected.
      3a2ace62
  16. May 06, 2013
  17. May 05, 2013
    • jsiegle's avatar
      Update format of settings file · 4d5a7d82
      jsiegle authored
      - Clean up methods in GenericProcessor
      - File selection now happens outside of EditorViewport
      - Add mechanism for saving custom parameters for individual channels
      - Settings file is automatically saved at the start of recording
      4d5a7d82
  18. Apr 28, 2013
  19. Apr 07, 2013
  20. Apr 05, 2013
    • jsiegle's avatar
      Run astyle to make code format more consistent · ea8c1c90
      jsiegle authored
      To run this in the future, install astyle (sudo apt-get install astyle),
      then enter the following from the top-level project directory:
      
      astyle --options=astyle.options --recursive "./Source/*.cpp" "./Source/*.h"
      
      This will convert tabs to 4 spaces and ensure that brackets are on
      their own lines.
      ea8c1c90
  21. Mar 21, 2013
    • jsiegle's avatar
      Change copyright year to 2013 · e36119a1
      jsiegle authored
      Use the following command to update the copyright year in all files,
      starting in the Source/ directory:
      
      find . -type f -print0 | xargs -0
         sed -i 's/Copyright (C) 2012/Copyright (C) 2013/g'
      
      Works like a charm!
      e36119a1
    • jsiegle's avatar
      Updated JUCE library · 637baf17
      jsiegle authored
      637baf17
  22. Feb 12, 2013
    • Marti Bolivar's avatar
      GenericProcessor: fix missing return values. · 8d0a53d4
      Marti Bolivar authored
      
      getInputChannelName() and getOutputChannelName() (pure virtual in the
      superclass) aren't returning anything. So far this hasn't triggered
      any memory errors because nobody's calling them.
      
      To hack around this, have both of these return
      "xxx-UNUSED-OPEN-EPHYS-xxx" (none of the existing subclases override
      these methods, so leaving them pure virtual isn't workable). This way,
      if we ever start calling these, we'll notice right away that a fix is
      needed (instead of segfaulting, etc.).
      
      Also keep them virtual to allow overrides.
      
      Signed-off-by: default avatarMarti Bolivar <mbolivar@leaflabs.com>
      8d0a53d4
    • Marti Bolivar's avatar
      GenericProcessor: don't return a reference to a stack variable. · e48cde4a
      Marti Bolivar authored
      
      That's not gonna work. Since nullParam is just a "nothing found", put
      it in static storage and return that.
      
      Signed-off-by: default avatarMarti Bolivar <mbolivar@leaflabs.com>
      e48cde4a
    • Marti Bolivar's avatar
      Fix up unused variable/value warnings. · 12574cf1
      Marti Bolivar authored
      
      Generic changes:
      
      - Genuinely unused variables (-Wunused-variable): delete
        them. Sometimes add a comment if the variable is for an extension of
        the code that isn't done yet.
      
      - Variables that became unused due to commented-out
        code (-Wunused-variable): comment out their definitions. Dirty, but
        that's because commenting out code instead of deleting it is
        dirty.
      
        Many of these are due to commented-out printlines that should have
        been log messages that only get emitted at high verbosity level.
      
      Specific changes:
      
      - SpikeObject.cpp (-Wunused-value): move initialization of loop
        variable into first for loop clause to silence the warning.
      
      Signed-off-by: default avatarMarti Bolivar <mbolivar@leaflabs.com>
      12574cf1
    • Marti Bolivar's avatar
      Resolve -Wreorder warnings. · efe43aa8
      Marti Bolivar authored
      
      Rearrange member initialization in constructors to silence GCC
      -Wreorder warnings (-Wreorder is enabled by -Wall).
      
      Signed-off-by: default avatarMarti Bolivar <mbolivar@leaflabs.com>
      efe43aa8
  23. Feb 06, 2013
  24. Jan 28, 2013
    • Ryan Maloney's avatar
      Saving Parameters · 58c8797d
      Ryan Maloney authored
      Uses the parameters array to create XML data for parameter settings on
      each channel when saving.
      
      This only works for processors that use the parameters array, though I
      updated LFP and Signal Generator to update that in parallel (LFP seems
      to have an unrelated bug in dealing with channels that is causing some
      problems). Eventually, all parameters should be used in the parameters
      array, since it opens up a lot of possible holes when using default
      values (they need to be specified twice), and once loading is
      implemented. I've fixed some of the problems with parameters, so this
      should be easier to do.
      
      As part of this, I also fixed the implementation of
      addParameterEditors. The old way of implementing a custom parameter
      editor was to rewrite the virtual function, but because it was called
      in the constructor, this didn't work (constructors use the type of the
      parent). Instead, all editors now also pass a bool
      "useDefaultParameterEditors" which is used by addParameterEditors() to
      determine whether to do anything. I think this is the best way to do
      it. It's initialized to default as true, though I had some trouble with
      it implicitly taking the argument and so had to add true to most of the
      editor functions (which is probably good practice anyway).
      
      I also fixed some of the functions for generic processor to get
      parameter index and parameter name.
      
      Obviously, this is of considerable less use without functions for
      loading parameters, but I figured it'd be better to make available for
      testing with just the loading in case the changes to Parameters broke
      anything I missed.
      58c8797d
  25. Dec 27, 2012
  26. Nov 20, 2012
  27. Nov 19, 2012
Loading