When many channels are selected for recording a race condition can cause a crash by writing to a file that has not been opened yet.

Cleanups and bugfixes caught by building with -Wall

It's unused, declared obsolete, and is triggering GCC warnings. If
anyone wants it back, it'll be in the Git history.

Signed-off-by: Marti Bolivar <mbolivar@leaflabs.com>

Signed-off-by: Marti Bolivar <mbolivar@leaflabs.com>

Signed-off-by: Marti Bolivar <mbolivar@leaflabs.com>

getInputChannelName() and getOutputChannelName() (pure virtual in the
superclass) aren't returning anything. So far this hasn't triggered
any memory errors because nobody's calling them.

To hack around this, have both of these return
"xxx-UNUSED-OPEN-EPHYS-xxx" (none of the existing subclases override
these methods, so leaving them pure virtual isn't workable). This way,
if we ever start calling these, we'll notice right away that a fix is
needed (instead of segfaulting, etc.).

Also keep them virtual to allow overrides.

Signed-off-by: Marti Bolivar <mbolivar@leaflabs.com>

That's not gonna work. Since nullParam is just a "nothing found", put
it in static storage and return that.

Signed-off-by: Marti Bolivar <mbolivar@leaflabs.com>

It looks like declaring them to return bool was a mistake:

1. None of their callers check their return value.

2. They don't return a value, and it doesn't look like there's any
   reason for them to.

Signed-off-by: Marti Bolivar <mbolivar@leaflabs.com>

If it's for internal use only, then enforce that.

Signed-off-by: Marti Bolivar <mbolivar@leaflabs.com>

Fixes caught by -Wreturn-type.

Have enable() properly return a value. Have disable() actually disable
the Arduino, and then properly return a value.

Signed-off-by: Marti Bolivar <mbolivar@leaflabs.com>

Signed-off-by: Marti Bolivar <mbolivar@leaflabs.com>

These patches have been submitted upstream:

https://github.com/vinniefalco/DSPFilters/pull/11



Signed-off-by: Marti Bolivar <mbolivar@leaflabs.com>

These patches have been submitted upstream:

https://github.com/vinniefalco/DSPFilters/pull/10



Signed-off-by: Marti Bolivar <mbolivar@leaflabs.com>

Generic changes:

- Genuinely unused variables (-Wunused-variable): delete
  them. Sometimes add a comment if the variable is for an extension of
  the code that isn't done yet.

- Variables that became unused due to commented-out
  code (-Wunused-variable): comment out their definitions. Dirty, but
  that's because commenting out code instead of deleting it is
  dirty.

  Many of these are due to commented-out printlines that should have
  been log messages that only get emitted at high verbosity level.

Specific changes:

- SpikeObject.cpp (-Wunused-value): move initialization of loop
  variable into first for loop clause to silence the warning.

Signed-off-by: Marti Bolivar <mbolivar@leaflabs.com>

Signed-off-by: Marti Bolivar <mbolivar@leaflabs.com>

Rearrange member initialization in constructors to silence GCC
-Wreorder warnings (-Wreorder is enabled by -Wall).

Signed-off-by: Marti Bolivar <mbolivar@leaflabs.com>

Processors fixups

We still hardcode paths, but this is better.

- Initialize lengthOfInputFile and bufferSize to 0 in case input isn't
  found.

- Pull call to fopen out of ifdefs, so a future patch can just rip out
  the hardcoded path parts.

- If input _is_ found, then don't leak the file descriptor when the
  FileReaderThread gets deleted.

- If input isn't found, emit a sensible error message and bail in the
  constructor when the file isn't found. Have subsequent calls that
  try to use the FileReaderThread fail instead of crash.

Signed-off-by: Marti Bolivar <mbolivar@leaflabs.com>

Signed-off-by: Marti Bolivar <mbolivar@leaflabs.com>

Signed-off-by: Marti Bolivar <mbolivar@leaflabs.com>

There's no such thing (type, variable, or otherwise) as a FileReader.

Signed-off-by: Marti Bolivar <mbolivar@leaflabs.com>