It's unused, declared obsolete, and is triggering GCC warnings. If
anyone wants it back, it'll be in the Git history.

Signed-off-by: Marti Bolivar <mbolivar@leaflabs.com>

Signed-off-by: Marti Bolivar <mbolivar@leaflabs.com>

Signed-off-by: Marti Bolivar <mbolivar@leaflabs.com>

Generic changes:

- Genuinely unused variables (-Wunused-variable): delete
  them. Sometimes add a comment if the variable is for an extension of
  the code that isn't done yet.

- Variables that became unused due to commented-out
  code (-Wunused-variable): comment out their definitions. Dirty, but
  that's because commenting out code instead of deleting it is
  dirty.

  Many of these are due to commented-out printlines that should have
  been log messages that only get emitted at high verbosity level.

Specific changes:

- SpikeObject.cpp (-Wunused-value): move initialization of loop
  variable into first for loop clause to silence the warning.

Signed-off-by: Marti Bolivar <mbolivar@leaflabs.com>

Rearrange member initialization in constructors to silence GCC
-Wreorder warnings (-Wreorder is enabled by -Wall).

Signed-off-by: Marti Bolivar <mbolivar@leaflabs.com>

We still hardcode paths, but this is better.

- Initialize lengthOfInputFile and bufferSize to 0 in case input isn't
  found.

- Pull call to fopen out of ifdefs, so a future patch can just rip out
  the hardcoded path parts.

- If input _is_ found, then don't leak the file descriptor when the
  FileReaderThread gets deleted.

- If input isn't found, emit a sensible error message and bail in the
  constructor when the file isn't found. Have subsequent calls that
  try to use the FileReaderThread fail instead of crash.

Signed-off-by: Marti Bolivar <mbolivar@leaflabs.com>

Signed-off-by: Marti Bolivar <mbolivar@leaflabs.com>

Signed-off-by: Marti Bolivar <mbolivar@leaflabs.com>

There's no such thing (type, variable, or otherwise) as a FileReader.

Signed-off-by: Marti Bolivar <mbolivar@leaflabs.com>