Skip to content
Snippets Groups Projects
  • Marti Bolivar's avatar
    8d0a53d4
    GenericProcessor: fix missing return values. · 8d0a53d4
    Marti Bolivar authored
    
    getInputChannelName() and getOutputChannelName() (pure virtual in the
    superclass) aren't returning anything. So far this hasn't triggered
    any memory errors because nobody's calling them.
    
    To hack around this, have both of these return
    "xxx-UNUSED-OPEN-EPHYS-xxx" (none of the existing subclases override
    these methods, so leaving them pure virtual isn't workable). This way,
    if we ever start calling these, we'll notice right away that a fix is
    needed (instead of segfaulting, etc.).
    
    Also keep them virtual to allow overrides.
    
    Signed-off-by: default avatarMarti Bolivar <mbolivar@leaflabs.com>
    8d0a53d4
    History
    GenericProcessor: fix missing return values.
    Marti Bolivar authored
    
    getInputChannelName() and getOutputChannelName() (pure virtual in the
    superclass) aren't returning anything. So far this hasn't triggered
    any memory errors because nobody's calling them.
    
    To hack around this, have both of these return
    "xxx-UNUSED-OPEN-EPHYS-xxx" (none of the existing subclases override
    these methods, so leaving them pure virtual isn't workable). This way,
    if we ever start calling these, we'll notice right away that a fix is
    needed (instead of segfaulting, etc.).
    
    Also keep them virtual to allow overrides.
    
    Signed-off-by: default avatarMarti Bolivar <mbolivar@leaflabs.com>
GenericProcessor.cpp 12.63 KiB